[riot-notifications] [RIOT-OS/RIOT] gnrc_sixlowpan_frag: make aggresive override configurable (#11442)
notifications at github.com
Thu Apr 25 09:46:44 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Currently, our 6Lo implementation always overrides the oldest reassembly buffer entry even if that one did not time out yet. While with larger reassembly buffers this can make sense to give newer datagrams precedence, smaller once suffer especially in multi-hop scenarios, where a router might reassemble multiple datagrams at once. As far as I am aware [RFC 4944](https://tools.ietf.org/html/rfc4944) does not mention this behavior, and I think I just adapted it from the legacy implementation back then. So it makes sense to make this aggressive behavior configurable.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Try compile with `CFLAGS += -DGNRC_SIXLOWPAN_FRAG_RBUF_AGGRESSIVE_OVERRIDE=0` and `CFLAGS += -DGNRC_SIXLOWPAN_FRAG_RBUF_AGGRESSIVE_OVERRIDE=1` both configurations should still work and when compiled with `-DGNRC_SIXLOWPAN_FRAG_RBUF_SIZE=1` larger datagrams should still be received with aggressive override deactivated when a node is pinged by two nodes while they are always not when aggressive override is activated.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
None, but incorporated at the moment into #11068.
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* gnrc_sixlowpan_frag: make aggresive override configurable
-- File Changes --
M sys/include/net/gnrc/sixlowpan/config.h (16)
M sys/net/gnrc/network_layer/sixlowpan/frag/rbuf.c (15)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications