[riot-notifications] [RIOT-OS/RIOT] makefile: fix implementation info-buildsizes-diff (#10966)

JonaRaemdonck notifications at github.com
Thu Apr 25 15:08:44 CEST 2019


Thanks for the feedback.

Actually this pull-request was about solving a problem that we created ourselves at our project. We decided to prepend the name of our outputted elf-files with the git hash of our current commit for identification purposes afterwards. This is simply incompatible with the current implementation of info-buildsizes-diff.

Instead I have made a custom make target that will stay within our own repo for now and solves our issue.

By revisiting this issue I did find some cumbersome functionality. If you build an image for a certain board on master and your branch, by running info-buildsizes-diff, you have no way of specifying for what boards you want that info, you'll get the info for all boards AND in both bindirs empty dirs will be generated for all compatible boards.

Do you think this is worth spending time on?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10966#issuecomment-486665192
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190425/90f13f93/attachment-0001.html>


More information about the notifications mailing list