[riot-notifications] [RIOT-OS/RIOT] drivers/adt7310: Replace binary literal with hex literal (#11450)
notifications at github.com
Thu Apr 25 21:42:35 CEST 2019
### Contribution description
This PR is related to PR #11352, where I suggest to add support for Linux' `/dev/spidev` devices to the native cpu. [As discussed](https://github.com/RIOT-OS/RIOT/pull/11352#issuecomment-486231452), enabling SPI causes the `tests/driver_adt7310` test to be run with the gnu and llvm toolchain. With the current configuration, these toolchains don't like binary literals in the code and raise a warning/error.
So I suggest to change the binary literal for `ADT7310_EXPECTED_MANUF_ID` to a hexadecimal one, so that I can then rebase the other PR and the Murdock build will no longer fail for this test.
### Testing procedure
I don't own an ADT7310 temperature sensor to test the change by myself, but I assume changing `0b1100000` to the equivalent `0bC0` in the code will have no impact besides removing compiler warnings. (The value is mentioned in table 10 of the [datasheet](https://www.analog.com/media/en/technical-documentation/data-sheets/ADT7310.pdf))
### Issues/PRs references
Required for PR #11352
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* drivers/adt7310: Replace binary representation
-- File Changes --
M drivers/adt7310/adt7310.c (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications