[riot-notifications] [RIOT-OS/RIOT] riotnode: node abstraction package (#10949)

Gaëtan Harter notifications at github.com
Fri Apr 26 18:19:06 CEST 2019


cladmi commented on this pull request.



> +    def _safe_term_close(self):
+        """Safe 'term.close'.
+
+        Handles possible exceptions.
+        """
+        try:
+            self.term.close()
+        except AttributeError:
+            # Not initialized
+            pass
+        except ProcessLookupError:
+            self.logger.warning('Process already stopped')
+        except pexpect.ExceptionPexpect:
+            # Not sure how to cover this in a test
+            # 'make term' is not killed by 'term.close()'
+            self.logger.critical('Could not close make term')

I may even maybe put a `started` variable. As currently when starting we wait some time. I will see with the multi nodes handling.
Also, the `start` could just do nothing if it is already started.

However I did not really see a use case for calling `start` multiple times. In the current tests, the test function receive a `started` child. So I assumed to somehow have this initialization done before anything else. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10949#discussion_r279016047
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190426/470eea3b/attachment.html>


More information about the notifications mailing list