[riot-notifications] [RIOT-OS/RIOT] pkg/nimble: adapt to nrf51 family (#11463)
notifications at github.com
Mon Apr 29 11:16:14 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This PR is adapting the Nimble package to make it compliant with nrf51 based boards. For the moment it needs a specific branch on my Apache-nimble fork (see https://github.com/apache/mynewt-nimble/pull/429).
I tested `examples/nimble_gatt` and it worked with `nrf51dk`. The `examples/nimble_scanner` doesn't work, maybe because of insufficient memory.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Build and flash `examples/nimble_gatt` on an nrf51 based board. It should appear in NRF connect application running on a Phone or using bluetoothctl on a Linux with bluetooth radio enabled.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* pkg/nimble: adapt to nrf51 family
* REMOVEME: point nimble package to specific version
-- File Changes --
M pkg/nimble/Makefile (8)
M pkg/nimble/Makefile.dep (4)
M pkg/nimble/Makefile.include (4)
M pkg/nimble/contrib/nimble_riot.c (5)
R pkg/nimble/drivers.mk (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications