[riot-notifications] [RIOT-OS/RIOT] gcoap: remove deprecated function gcoap_req_send() (#11445)
notifications at github.com
Tue Apr 30 20:08:33 CEST 2019
kb2ma requested changes on this pull request.
Thanks @miri64! I agree gcoap_req_send() has been deprecated long enough. It also makes sense to deprecate gcoap_req_send2() now. Your changes are straightforward.
A few other places need to be updated. Look for "gcoap_req_send2" in the repository. This includes the module documentation, uses by cord_ep and cord_ep_sim, and the gcoap example.
Finally, if we have not developed a deprecation window policy, I would be inclined to keep the deprecated gcoap_req_send2() until the 2020.01 release. I expect almost everyone that uses gcoap also uses this function. So since there are 3 gcoap users, then probably 2 of them use it. I wouldn't want to make both of them mad. :-)
> * @param[in] resp_handler Callback when response received, may be NULL
* @return length of the packet
* @return 0 if cannot send
-size_t gcoap_req_send(const uint8_t *buf, size_t len, const ipv6_addr_t *addr,
- uint16_t port, gcoap_resp_handler_t resp_handler);
+size_t gcoap_req_send2(const uint8_t *buf, size_t len,
You intention was to inline this, right?
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications