[riot-notifications] [RIOT-OS/RIOT] shell_commands: adapt ping6 to original-ping-like implementation (#9523)

Cenk Gündoğan notifications at github.com
Fri Feb 1 07:08:20 CET 2019


cgundogan commented on this pull request.



> +
+        msg_receive(&msg);
+        switch (msg.type) {
+            case GNRC_NETAPI_MSG_TYPE_RCV: {
+                _handle_reply(&data, msg.content.ptr);
+                gnrc_pktbuf_release(msg.content.ptr);
+                break;
+            }
+            case _SEND_NEXT_PING:
+                _pinger(&data);
+                break;
+            case _PING_FINISH:
+                goto finish;
+            default:
+                /* requeue wrong packets */
+                msg_send(&msg, sched_active_pid);

What other messages can appear here? Shouldn't they be dropped instead of requeued? I can't see another `msg_recv` anywhere here that handles other types of messages, so the queue would get full with garbage ..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9523#pullrequestreview-198935368
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190131/f711444b/attachment.html>


More information about the notifications mailing list