[riot-notifications] [RIOT-OS/RIOT] tests: add tests to reproduce #10881 (#10908)

Alexandre Abadie notifications at github.com
Fri Feb 1 08:15:10 CET 2019


aabadie commented on this pull request.



> +# Copyright (C) 2019 Freie Universit├Ąt Berlin
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+
+import sys
+from testrunner import run
+from pexpect import TIMEOUT
+
+
+def testfunc(child):
+    res = child.expect([TIMEOUT, "FAILED ASSERTION."])
+    # we actually want the timeout here. The application runs into an assertion
+    # pretty quickly when failing and runs forever on success
+    assert(res == 0)

> but if and return are not function-like

In Python, `assert` is not considered as a function. That's my point. Which is not about style, but about correct the use of a programming language. Also I don't understand why you talk about `sizeof`. C is a different language, with different rules.

> I would replace this with an assertRaises()

I guess you meant `assertEqual`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10908#discussion_r252952232
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190131/5002e1cf/attachment-0001.html>


More information about the notifications mailing list