[riot-notifications] [RIOT-OS/RIOT] cpu/esp*: Xtensa vendor code moved to esp_common (#10883)

Sebastian Meiling notifications at github.com
Fri Feb 1 09:29:31 CET 2019


smlng commented on this pull request.

nice consolidation

> @@ -183,7 +183,7 @@ char* thread_stack_init(thread_task_func_t task_func, void *arg, void *stack_sta
 
     uint32_t *p;
 
-    p = (uint32_t *)(((uint32_t) top_of_stack+1 - XT_CP_SIZE));
+    p = (uint32_t *)(((uint32_t)(top_of_stack + 1) - XT_CP_SIZE) & ~0xf);

this looks different than the before (added ` & ~0xf`).  I'm not in to any details here, just pointing out so you can check.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10883#pullrequestreview-198966539
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190201/63b1e07a/attachment.html>


More information about the notifications mailing list