[riot-notifications] [RIOT-OS/RIOT] drivers/cc110x: Fixed MTU calculation (#10918)

Martine Lenders notifications at github.com
Fri Feb 1 15:16:49 CET 2019


miri64 commented on this pull request.



>          case NETDEV_TYPE_IEEE802154:
         case NETDEV_TYPE_NRFMIN:
 #ifdef MODULE_GNRC_SIXLOWPAN_IPHC
             netif->flags |= GNRC_NETIF_FLAGS_6LO_HC;
 #endif
             /* intentionally falls through */
+        case NETDEV_TYPE_CC110X:

> I actually had it like that before, but the driver received 6LoWPAN layer 2 fragments that where bigger than the maximum PDU signaled by the driver. I will re-check if that was indeed the case.

Sounds like a bug. If I find the time I will test later with an MSB-A2 to see what you mean

> If that is indeed the case, where should the header compression occur? I assumed that this needs to be either implemented or enabled at some point and was going to add this later on.

You would not not need to do anything `gnrc_sixlowpan_iphc` will start compressing once the `GNRC_NETIF_FLAGS_6LO_HC` flag is set in the netif (which it is in the line above). So once you move the line up, it *should* work out of the box.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10918#discussion_r253063964
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190201/52bac768/attachment-0001.html>


More information about the notifications mailing list