[riot-notifications] [RIOT-OS/RIOT] sys: Add RIOT Registry implementation (#10799)

danpetry notifications at github.com
Mon Feb 4 15:49:20 CET 2019


Hi Leandro, sorry for the delay

> Are you suggesting to add a test app per storage facility?  I think that may be overkill, the only thing to change on the test app is the Makefile to select the wanted storage 

Are there any other tests where the makefile needs to be changed or there are `#defines` to change tests? If so, then I'm ok with this. (I saw the unittests btw - looks good at first glance, thank you, and all the tests build correctly for the platforms I tried)

>  an example would be worth when other modules of the Runtime Configuration System are merged

sounds sensible

> Check the updated code and please point out the edge cases

I'll have a closer look while doing the next round of review, maybe write some extra tests as a PR

> SFs are placed under sys/registry/store. The handlers are implemented in apps or other modules, so they should not be placed in the registry folder.

ok, seems sensible, doesn't seem like it's feasible to make it symmetric

All other points on your post I would say agreed/fine/etc for. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10799#issuecomment-460275928
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190204/ee6d9082/attachment.html>


More information about the notifications mailing list