[riot-notifications] [RIOT-OS/RIOT] gnrc_netif_ieee802154: drop duplicate broadcast packets (optionally) (#7577)

Martine Lenders notifications at github.com
Mon Feb 4 19:21:34 CET 2019


miri64 commented on this pull request.



> @@ -73,6 +73,20 @@ static gnrc_pktsnip_t *_make_netif_hdr(uint8_t *mhr)
     return snip;
 }
 
+#if MODULE_GNRC_NETIF_DEDUP
+static inline bool _already_received(gnrc_netif_t *netif,
+                                     gnrc_netif_hdr_t *netif_hdr,
+                                     uint8_t *mhr)

 > About that fact that we need three "data structures" in order to get header information such as sequence number or link layer addresses.

For that we "only" need two. The third (`netif`) is the current state against we check that information. We wouldn't actually need two either, but the addresses in the IEEE 802.15.4 are rather complicated to parse out due to its and their variable lengths, so why not actually use the results from a previous parsing step i.e. `netif_hdr` (we don't need the sequence number in that for most use-cases)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7577#discussion_r253584717
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190204/5aca6d06/attachment.html>


More information about the notifications mailing list