[riot-notifications] [RIOT-OS/RIOT] [WIP] suit: Initial minimal SUIT parser (#10315)

Koen Zandberg notifications at github.com
Mon Feb 4 21:39:20 CET 2019


> Would you be able to update it to the latest SUIT version (v3, [here](https://datatracker.ietf.org/doc/draft-moran-suit-manifest/))? I'll review it before v4 for sure.

After some offline online discussion with @emmanuelsearch we decided to keep this the v1.

> Not tested: suit_uuid_xxx functions (apart from init); suit_isnew. Could you please include explicit tests?

Will do.

> This is a _CBOR_ SUIT parser specifically; other serialization formats are possible. Could you please indicate this in the module name OR abstract away the CBOR-specific stuff so that we can use other serialization formats with this code?

Version 3 of the draft explicitly calls is a "CBOR-based Firmware Manifest Serialisation Format". Despite this would you still like to have support for different serialization formats?

> Maybe take the reference to block1 out of the brief, because we have block 2 now as well (i.e. so it just says you need an in-place buffer)

Done

> Please split uuid_init as planned (although keeping this function to initialise everything together would also be useful)

On it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10315#issuecomment-460404139
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190204/89d48df4/attachment.html>


More information about the notifications mailing list