[riot-notifications] [RIOT-OS/RIOT] Pr/bug/testrunner/matching local echo (#10952)
notifications at github.com
Tue Feb 5 16:10:58 CET 2019
### Contribution description
When local echo is enabled, pexpect will also match on send lines to the
node. So could think a node is echoing when it is only seeing the sent
The sent messages are still written to `logfile` but now only once.
This may show issues with our current tests implementation that expected
### Testing procedure
I included a test commit to show the fixed issue.
Sending a string to `hello-world` and matching on the same string works in master even if the nodes does not echo anything.
When running the test commit alone, it will fail with a `RuntimeError` to show the erroneous behavior.
With the `disable local echo` fix, the test passes.
# both with native and a board to show it is not a `pyterm` issue
BOARD=native make -C examples/hello-world flash test
BOARD=samr21-xpro make -C examples/hello-world flash test
I will retry all our test suite on this:
* [ ] `native`
* [ ] `samr21-xpro`
### Issues/PRs references
Found while implementing https://github.com/RIOT-OS/RIOT/pull/10949 based on `testrunner` handling.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* TEST COMMIT REMOVE ME: add a test that 'hello-world' does not echo
* testrunner: disable local echo
-- File Changes --
M dist/pythonlibs/testrunner/__init__.py (3)
A examples/hello-world/tests/01-run.py (24)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications