[riot-notifications] [RIOT-OS/RIOT] net/gnrc_tcp: timeout of connection establishment (#10945)

Simon Brummer notifications at github.com
Wed Feb 6 10:24:03 CET 2019

Ah okay. There is still room for improvement. A received SYN without any source or destination address should not be accepted as a valid SYN anyway and therefore a sending of a SYN+ACK/RST+ACK should not occur.

However you are right with the proposed change, at least the deadlock vanishes. RST+ACK is like SYN+ACK, something the receiver has to respond with an ACK. In case the the peer never ACKs the previous request, the RIOT Node would stay locked without #10946.
>From what I have seen the sending of the initial SYN with source addr = "::" is either caused by
1) The setup in the current gnrc_tcp tests.
2) Something else in the network stack (I think this is unlikely).

To improve the situation:
1) The current test should be improved to cause as less problems as possible.
2) The TCP layer handling thread should, assert in cases where an invalid IP-Address enters or leaves the TCP layer.  With that check it might be easier to nail down such issues in the future.

I would like to address both measures soon. Any objections or additional ideas?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190206/9fca5d7e/attachment.html>

More information about the notifications mailing list