[riot-notifications] [RIOT-OS/RIOT] pkg: add pkg libbase58 (#10957)

Martine Lenders notifications at github.com
Wed Feb 6 19:19:16 CET 2019


miri64 commented on this pull request.



> +
+#include "libbase58.h"
+#include "embUnit.h"
+
+static void setUp(void)
+{
+}
+
+static void test_libbase58_01(void)
+{
+    const char source[] = "base 58 test string";
+    const char encoded[] = "K1cpEhnSEL8mbBfpp7f6z3dSZ4";
+    char target[64] = {0};
+    size_t target_len = sizeof(target);
+
+    b58enc(target, &target_len, source, sizeof(source)-1);

Questions for testing:

- What about decoding tests (also a doc question: is there a decoding function)?
- What happens if I throw in a NULL pointer?
- What happens if the string is empty?
- Does it still work if I provide a source length that `source` actually is?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10957#pullrequestreview-200728216
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190206/43ed8906/attachment.html>


More information about the notifications mailing list