[riot-notifications] [RIOT-OS/RIOT] gnrc_tcp-change and verfy addrs in use (#10963)

Peter Kietzmann notifications at github.com
Thu Feb 7 09:17:14 CET 2019

PeterKietzmann requested changes on this pull request.

Please don't forget to adapt the README files.

Other than that I can confirm it fixes the issue with native. Running on boards I get this failed assertion on the client which is triggered in the NIB: [`sys/net/gnrc/network_layer/ipv6/nib/_nib-internal.c:317 => 0xbb5`](https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/network_layer/ipv6/nib/_nib-internal.c#L317)

+TCP_LOCAL_ADDR ?= 2001:db8::affe:0002

Now that the IP address has a global scope I find it a bit misleading to name this variable `..._LOCAL_...`. How about something crazy like client/server?

> @@ -54,6 +76,25 @@ int main(void)
     return 0;
+bool verify_ip_addr(gnrc_netif_t *netif)
+    ipv6_addr_t must_match;
+    if (!ipv6_addr_from_str(&must_match, LOCAL_ADDR)) {
+        return false;
+    }
+    for (int i = 0; i < GNRC_NETIF_IPV6_ADDRS_NUMOF; ++i) {
+        bool ip_match = ipv6_addr_equal(&must_match, &(netif->ipv6.addrs[i]));

I think I still don't really understand why this is actually necessary (of course I know it's because of the source address issue we had). Would you spend a note?

> @@ -7,7 +7,7 @@ ifeq (native,$(BOARD))
   PORT ?= tap0
-TCP_LOCAL_ADDR ?= fe80::affe
+TCP_LOCAL_ADDR ?= 2001:db8::affe:0001

Se above comment about naming.

> @@ -72,6 +78,25 @@ int main(void)
     return 0;
+bool verify_ip_addr(gnrc_netif_t *netif)

This duplication is ugly. Do we actually need this on the server side?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190207/b7bd5466/attachment.html>

More information about the notifications mailing list