[riot-notifications] [RIOT-OS/RIOT] cpu/cc260x: add I2C implementation (#10955)

MrKevinWeiss notifications at github.com
Thu Feb 7 09:53:39 CET 2019


So here are some things I found, I leave it to you to determine if they are a problem:
- the speed seems fast for the internal pullups, I needed external pullups to get reliable communication (I don't even know if they have internal pullups)
- There is no recovery from NACK in the read bytes (so if you nack an address then try to read bytes after it gives EIO)
- It appears that you write a byte even if a NACK occurs on the write
- No protection for incorrect flag usage, (sending an I2C_NOSTART read/write bytes without checking if the bus is busy first)

Overall I would say it is usable in most applications, just a few corner cases that are not covered (sometimes, depending on hardware, they can be quite hard).

Here are the [test results](https://gist.github.com/MrKevinWeiss/e96973e854f88ea6e9126fbe762f0002) after altering the test to not read bytes after NACK (because I didn't connect the reset pin)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10955#issuecomment-461334998
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190207/70141384/attachment.html>


More information about the notifications mailing list