[riot-notifications] [RIOT-OS/RIOT] gnrc_tcp-change and verfy addrs in use (#10963)

Peter Kietzmann notifications at github.com
Thu Feb 7 09:55:35 CET 2019


PeterKietzmann commented on this pull request.



> @@ -72,6 +78,25 @@ int main(void)
     return 0;
 }
 
+bool verify_ip_addr(gnrc_netif_t *netif)

Fine with the duplication for now... 

About the function itself: I do understand that you want to verify the address. **But** verification itself should not be the fix for the actual issue. If this was the case, I'd expect that some setup delay of the IPv6 address was causing the issue and with your verification, you just delay the process until the address was set up properly (or return false). Even that would be fine with me. But then I'd like to see that information in form of a comment.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10963#discussion_r254590562
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190207/28662ab7/attachment-0001.html>


More information about the notifications mailing list