[riot-notifications] [RIOT-OS/RIOT] cpu/esp8266: removes netstats in esp wifi netdev driver (#10965)

Sebastian Meiling notifications at github.com
Thu Feb 7 15:11:38 CET 2019


smlng requested changes on this pull request.

otherwise testedACK

> @@ -455,18 +451,11 @@ static int IRAM _send(netdev_t *netdev, const iolist_t *iolist)
 
     if (res == ERR_OK) {
         /* There was no ieee80211_output_pbuf error and no send timeout. */
-#ifdef MODULE_NETSTATS_L2
-        netdev->stats.tx_bytes += iol_len;
-        netdev->event_callback(netdev, NETDEV_EVENT_TX_COMPLETE);

this should stay in somehow, see other netdev implementations, e.g. also esp32 esp_wifi

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10965#pullrequestreview-201102220
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190207/bf26b096/attachment-0001.html>


More information about the notifications mailing list