[riot-notifications] [RIOT-OS/RIOT] boot: Moved stdio_init() into periph_init() (#10806)

Gunar Schorcht notifications at github.com
Thu Feb 7 17:40:00 CET 2019


@maribu If you don't want to make the call of `stdio_init` dependent on the existence of any `stdio_*` module, these would be the changes for ESP8266 and ESP32.
```diff
diff --git a/cpu/esp32/Makefile.dep b/cpu/esp32/Makefile.dep
index c5d8e5803..59f319042 100644
--- a/cpu/esp32/Makefile.dep
+++ b/cpu/esp32/Makefile.dep
@@ -91,10 +91,6 @@ ifneq (,$(filter xtimer,$(USEMODULE)))
     USEMODULE += newlib_syscalls_default
 endif
 
-ifneq (,$(filter newlib_syscalls_default,$(USEMODULE)))
-    USEMODULE += stdio_uart
-endif
-
 # if SPI RAM is enabled, ESP-IDF heap and quot flash mode have to be used
 ifneq (,$(filter esp_spi_ram,$(USEMODULE)))
     USEMODULE += esp_idf_heap
diff --git a/cpu/esp32/Makefile.include b/cpu/esp32/Makefile.include
index 738fcbd71..81c20338e 100644
--- a/cpu/esp32/Makefile.include
+++ b/cpu/esp32/Makefile.include
@@ -69,6 +69,7 @@ USEMODULE += log
 USEMODULE += periph
 USEMODULE += periph_common
 USEMODULE += random
+USEMODULE += stdio_uart
 USEMODULE += xtensa
 
 INCLUDES += -I$(RIOTCPU)/$(CPU)/vendor/
diff --git a/cpu/esp8266/Makefile.dep b/cpu/esp8266/Makefile.dep
index cc2422d6f..167b4231c 100644
--- a/cpu/esp8266/Makefile.dep
+++ b/cpu/esp8266/Makefile.dep
@@ -48,6 +48,10 @@ ifneq (, $(filter shell, $(USEMODULE)))
     USEMODULE += xtimer
 endif
 
+ifneq (, $(filter stdio_uart, $(USEMODULE)))
+    USEMODULE += xtimer
+endif
+
 ifneq (, $(filter xtimer, $(USEMODULE)))
     USEMODULE += newlib_syscalls_default
 endif
@@ -56,7 +60,3 @@ ifneq (, $(filter vfs, $(USEMODULE)))
     USEMODULE += newlib_syscalls_default
     USEMODULE += xtimer
 endif
-
-ifneq (, $(filter newlib_syscalls_default, $(USEMODULE)))
-    USEMODULE += stdio_uart
-endif
diff --git a/cpu/esp8266/Makefile.include b/cpu/esp8266/Makefile.include
index 4658d192a..369a8be21 100644
--- a/cpu/esp8266/Makefile.include
+++ b/cpu/esp8266/Makefile.include
@@ -62,6 +62,7 @@ USEMODULE += periph_common
 USEMODULE += ps
 USEMODULE += random
 USEMODULE += sdk
+USEMODULE += stdio_uart
 USEMODULE += xtensa
 
 ifneq (, $(filter pthread, $(USEMODULE)))
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10806#issuecomment-461503214
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190207/08646f33/attachment.html>


More information about the notifications mailing list