[riot-notifications] [RIOT-OS/RIOT] [backport] drivers/w5100: Fixed netdev_driver_t::recv() API (#10973)

Marian Buschsieweke notifications at github.com
Fri Feb 8 12:40:52 CET 2019


Backport of https://github.com/RIOT-OS/RIOT/pull/10412

### Contribution description

The current implementation of the `netdev_driver_t::recv()` API in the W5100 driver does not comply with documentation:

 - The drop feature of `recv()` is not implemented
 - In case of a too small buffer no error is returned and the frame is silently truncated. The API mandates returning `-ENOBUFS`

### Testing procedure

It would be nice to add a test application for this, as many drivers are affected...

### Issues/PRs references

https://github.com/RIOT-OS/RIOT/issues/10410, https://github.com/RIOT-OS/RIOT/issues/10413
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/10973

-- Commit Summary --

  * drivers/w5100: Added missing drop implementation
  * drivers/w5100: Fix recv() with too small buffer

-- File Changes --

    M drivers/w5100/w5100.c (45)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/10973.patch
https://github.com/RIOT-OS/RIOT/pull/10973.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10973
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190208/5ddd611c/attachment.html>


More information about the notifications mailing list