[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib/nc: remove from _next_removable on remove (#10975)

Martine Lenders notifications at github.com
Fri Feb 8 23:36:46 CET 2019


miri64 commented on this pull request.



> @@ -302,6 +302,10 @@ static void test_nib_iter__three_elem_middle_removed(void)
     addr.u64[1].u64++;
     TEST_ASSERT_NOT_NULL((node3 = _nib_onl_alloc(&addr, IFACE)));
     node3->mode = _DRL;
+    /* cppcheck-suppress redundantAssignment
+     * (reason: we assigned _FT before so _nib_onl_alloc would recognize node2
+     *          as used, now we want to clear it, so we need to set it to
+     *          _EMPTY... we are testing internals of data structures here) */

Unrelated but needed to pass CI.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10975#pullrequestreview-201814277
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190208/bfd97496/attachment-0001.html>


More information about the notifications mailing list