[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: release packet when NC entry can't be added (#10978)

Cenk Gündoğan notifications at github.com
Mon Feb 11 11:13:47 CET 2019

cgundogan commented on this pull request.

> @@ -1130,6 +1130,7 @@ static bool _resolve_addr(const ipv6_addr_t *dst, gnrc_netif_t *netif,
             entry = _nib_nc_add(dst, (netif != NULL) ? netif->pid : 0,
             if (entry == NULL) {
+                gnrc_pktbuf_release(pkt);

Hm, while releasing the pktsnip in case of ENOMEM is sensible, might this not interfere with the lines in https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/network_layer/ipv6/nib/nib.c#L203:L209, for `netif == NULL`? From looking at the code, this line can also be reached when `netif == NULL`, in which case the pktsnip is released and later again with `gnrc_pktbuf_release_error`.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190211/65799847/attachment.html>

More information about the notifications mailing list