[riot-notifications] [RIOT-OS/RIOT] [BUG] testrunner matching local echo (#10952)

Gaëtan Harter notifications at github.com
Mon Feb 11 12:33:44 CET 2019


@MrKevinWeiss We see the message on both boards, it is displayed before on `nucleo-f103rb`. And yes it is expected as all messages sent are saved to the `logfile`.

A test for this is important, but I would not put it in `examples/hello-world`.
Here it is not really testing `hello-world` just using one of its property to test something else.

I found about it while testing the `riotnode` wrapping https://github.com/RIOT-OS/RIOT/pull/10949
(Currently is only a rewrite as a class on the pexpect initialization).
And have a dedicated library only test using a fake node over there:

https://github.com/cladmi/RIOT/commit/f386f3997beb19d1074b082e70116f0f4c8abac7

Would that be enough or do you prefer to also have a board test for this too ?

One issue I see for tests with a real board is that it may require multiple firmwares for testing everything. But it could make sense to have a few directories in `test/` to handle these integration tests too.

With all this, should I add dedicated test to this PR instead of the throwaway commit ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10952#issuecomment-462297018
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190211/481e8131/attachment-0001.html>


More information about the notifications mailing list