[riot-notifications] [RIOT-OS/RIOT] Introduce module vars (#10928)

Gaƫtan Harter notifications at github.com
Mon Feb 11 17:20:34 CET 2019


> > For the implementation detail, I am not in favor of the magic part with the `foreach`
> 
> What would you propose?

Be explicit with `CFLAGS += $(call add_module_specific_variables,CFLAGS)`

I would then easily find all things defining CFLAGS with only `grep`.
And the variable could also be defined at different places in the parsing if needed.

One thing I just think about, some definitions may not be suitable to be set like this when the definition order matters. Not blocking or anything just need to be documented that they should work with any definition order.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10928#issuecomment-462390389
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190211/595d7854/attachment-0001.html>


More information about the notifications mailing list