[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib/arsm: ensure proper int width in backoff calculation (#10369)

Gaƫtan Harter notifications at github.com
Tue Feb 12 15:02:01 CET 2019


This test fails without the `uint64_t`:

``` diff
+
+    /* Tests 64bit overfrow */
+    TEST_ASSERT_EQUAL_INT(NDP_MAX_RETRANS_TIMER_MS,
+            _exp_backoff_retrans_timer_factor(NDP_MAX_NS_NUMOF,
+                                              32768,
+                                              1024));
```

I chose power of two values on purpose for simplicity and they should be in range

```
git grep -e  'define NDP_MAX_RETRANS_TIMER_MS' -e 'define NDP_MIN_RANDOM_FACTOR' -e 'define NDP_MAX_RANDOM_FACTOR'
sys/include/net/ndp.h:#define NDP_MAX_RETRANS_TIMER_MS    (60000U)
sys/include/net/ndp.h:#define NDP_MIN_RANDOM_FACTOR       (500U)      /**< MIN_RANDOM_FACTOR (x 1000) */
sys/include/net/ndp.h:#define NDP_MAX_RANDOM_FACTOR       (1500U)     /**< MAX_RANDOM_FACTOR (x 1000) */
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10369#issuecomment-462770451
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190212/97f83cc9/attachment-0001.html>


More information about the notifications mailing list