[riot-notifications] [RIOT-OS/RIOT] tests/rng: replace printf_float with fmt/print_float (#10999)

Martine Lenders notifications at github.com
Tue Feb 12 18:45:54 CET 2019


miri64 commented on this pull request.



> @@ -154,7 +154,7 @@ void test_distributions(uint32_t samples)
 
         /* count bits */
         for (int i = 0; i < 32; i++) {
-            if (value & (1 << i)) {
+            if (value & (1u << i)) {

Shouldn't it be `1LU` to fit 32-bit?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10999#pullrequestreview-202812827
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190212/94c322f2/attachment.html>


More information about the notifications mailing list