[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6_nib: fix preparation of delayed NA (#10985)

Cenk Gündoğan notifications at github.com
Tue Feb 12 20:08:30 CET 2019


cgundogan approved this pull request.

Code-wise ACK. I have a minor question embedded here in the review that I would like to have an answer to, though.

>          return;
     }
-    nce = _nib_onl_get(tgt, netif->pid);
-    if ((nce != NULL) && (nce->mode & _NC)) {
-        /* usually this should be the case, but when NCE is full, just
-         * ignore the sending. Other nodes in this anycast group are
-         * then preferred */
-        _evtimer_add(nce, GNRC_IPV6_NIB_SND_NA, &nce->snd_na,
-                     random_uint32_range(0, NDP_MAX_ANYCAST_MS_DELAY));
+    pkt = gnrc_ipv6_hdr_build(payload, NULL, &ipv6_hdr->src);
+    if ((payload = _check_release_pkt(pkt, payload)) == NULL) {
+        return;
+    }
+    ((ipv6_hdr_t *)payload->data)->hl = 255;

why `255` and not the configured default for the interface?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10985#pullrequestreview-202852596
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190212/f25e0a78/attachment.html>


More information about the notifications mailing list