[riot-notifications] [RIOT-OS/RIOT] core: API and datatype change for handling thread states (#10989)

Martine Lenders notifications at github.com
Wed Feb 13 13:44:53 CET 2019


miri64 approved this pull request.

Code-wise the change looks good to me. I also compiled the `tests/bench_*` tests for `z1` (MSP-430) and got the following size differences (`bin-master` is  f8a7c026f2a83a29323, the current merge-base of this PR with master, and `bin` is 3eb7953, the current `HEAD` of this PR when I did this). In both cases I used `RIOT_VERSION_OVERRIDE=""`.

```
text	data	bss	dec	BOARD/BINDIRBASE
-14	0	0	-14	z1
7294	16	1582	8892	master-bin
7280	16	1582	8878	bin

tests_bench_mutex_pingpong
text	data	bss	dec	BOARD/BINDIRBASE
-10	0	0	-10	z1
6648	16	1584	8248	master-bin
6638	16	1584	8238	bin

tests_bench_runtime_coreapis
text	data	bss	dec	BOARD/BINDIRBASE
8	0	0	8	z1
7946	16	1080	9042	master-bin
7954	16	1080	9050	bin

tests_bench_sched_nop
text	data	bss	dec	BOARD/BINDIRBASE
-6	0	0	-6	z1
6326	16	1068	7410	master-bin
6320	16	1068	7404	bin

tests_bench_sizeof_coretypes
text	data	bss	dec	BOARD/BINDIRBASE
-6	0	0	-6	z1
5622	16	1046	6684	master-bin
5616	16	1046	6678	bin

tests_bench_thread_flags_pingpong
text	data	bss	dec	BOARD/BINDIRBASE
6	0	0	6	z1
6540	16	1580	8136	master-bin
6546	16	1580	8142	bin

tests_bench_thread_yield_pingpong
text	data	bss	dec	BOARD/BINDIRBASE
-6	0	0	-6	z1
6378	16	1580	7974	master-bin
6372	16	1580	7968	bin

tests_bench_timers
text	data	bss	dec	BOARD/BINDIRBASE
-10	0	0	-10	z1
15770	130	3248	19148	master-bin
15760	130	3248	19138	bin
```

Here are the test results (first f8a7c026f2a83a29323bfcef19b88f8cd28a0d47 then 3eb7953):

- `tests/bench_msg_pingpong`: increase in performance (9562 / 9596)
- `tests/bench_mutex_pingpong`: increase in performance (10131 / 10196)
- `tests/bench_runtime_coreapis`: no performance change
- `tests/bench_sched_nop`: increase in performance (36667 / 36836)
- `tests/bench_sizeof_coretypes` size of `tcp->status` increases from 1 to 2. Due to alignment padding the size of `thread_t` raises by 2 from 26 to 28.
- `tests/bench_thread_flags_pingpong`: decrease in performance (9930 / 9893)
- `tests/bench_thread_yield_pingpong`: increase in performance (16653 / 16723)
- `tests/bench_timers`: I get an error in both cases `Error -1 intializing reference timer` (so unrelated + I believe that test has nothing to do with the others ;-))

(remark: `make test` failed for `bench_runtime_coreapis` here https://github.com/RIOT-OS/RIOT/blob/f8a7c026f2a83a29323bfcef19b88f8cd28a0d47/tests/bench_runtime_coreapis/tests/01-run.py#L24 in both f8a7c026f2a83a29323bfcef19b88f8cd28a0d47 and 3eb7953. I guess the timeout of the expect is just a bit too tight for the MSP-430)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10989#pullrequestreview-203189230
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190213/c5436b0b/attachment-0001.html>


More information about the notifications mailing list