[riot-notifications] [RIOT-OS/RIOT] ndp: provide define for common hop-limit (#11011)

Alexandre Abadie notifications at github.com
Thu Feb 14 09:29:42 CET 2019


aabadie requested changes on this pull request.

git grep is reporting other uses of 255: in debug messages, in `tests/gnrc_ipv6_nib/main.c` and in `tests/gnrc_ipv6_nib_6ln/main.c`. I think they should be adapted as well.

```
$ git grep 'ipv6->hl'
sys/net/gnrc/network_layer/ipv6/nib/nib.c:    if (!(gnrc_netif_is_rtr(netif)) || (ipv6->hl != 255U) ||
sys/net/gnrc/network_layer/ipv6/nib/nib.c:        DEBUG("     - IP Hop Limit: %u (should be 255)\n", ipv6->hl);
sys/net/gnrc/network_layer/ipv6/nib/nib.c:        (ipv6->hl != 255U) || (rtr_adv->code != 0U) ||
sys/net/gnrc/network_layer/ipv6/nib/nib.c:        DEBUG("     - IP Hop Limit: %u (should be 255)\n", ipv6->hl);
sys/net/gnrc/network_layer/ipv6/nib/nib.c:    if ((ipv6->hl != 255U) || (nbr_sol->code != 0U) ||
sys/net/gnrc/network_layer/ipv6/nib/nib.c:        DEBUG("     - IP Hop Limit: %u (should be 255)\n", ipv6->hl);
sys/net/gnrc/network_layer/ipv6/nib/nib.c:    if ((ipv6->hl != 255U) || (nbr_adv->code != 0U) ||
sys/net/gnrc/network_layer/ipv6/nib/nib.c:        DEBUG("     - IP Hop Limit: %u (should be 255)\n", ipv6->hl);
sys/shell/commands/sc_gnrc_icmpv6_echo.c:    ipv6->hl = data->hoplimit;
tests/gnrc_ipv6_nib/main.c:    ipv6->hl = 255U;
tests/gnrc_ipv6_nib/main.c:    ipv6->hl = 255U;
tests/gnrc_ipv6_nib/main.c:    ipv6->hl = ipv6_hl;
tests/gnrc_ipv6_nib/main.c:    ipv6->hl = ipv6_hl;
tests/gnrc_ipv6_nib/main.c:    ipv6->hl = ipv6_hl;
tests/gnrc_ipv6_nib/main.c:    ipv6->hl = ipv6_hl;
tests/gnrc_ipv6_nib_6ln/main.c:    ipv6->hl = 255U;
tests/gnrc_ipv6_nib_6ln/main.c:    ipv6->hl = ipv6_hl;
tests/gnrc_ipv6_nib_6ln/main.c:    ipv6->hl = ipv6_hl;
tests/gnrc_ipv6_nib_6ln/main.c:    ipv6->hl = ipv6_hl;
tests/gnrc_ipv6_nib_6ln/main.c:    ipv6->hl = ipv6_hl;
```



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11011#pullrequestreview-203616316
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190214/82699f31/attachment.html>


More information about the notifications mailing list