[riot-notifications] [RIOT-OS/RIOT] drivers/motor_driver: driver for analogic H-bridge driving DC motors (#10290)

Gilles DOFFE notifications at github.com
Thu Feb 14 14:07:40 CET 2019


@jcarrano Hi Juan,

Sorry for the answer delays. The murdock CI was really painful to me but very useful and helpful to make some last improvements and corrections.

1. Creating nucleo-f446re specific board.h breaks the use of common nucleo64 board.h. So do not create **boards/nucleo-f446re/include/board.h** and add motor description into **boards/common/nucleo64/include/board.h**. So that all nucleo64 boards can test it.
2. In board.h from native board, motors description is conditioned to not use C++ as C++ standards does not handle designated initialiers.
3. I added motor_driver pwm requirement into **drivers/Makefile.dep**

The PR is squashed and ready on my side.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10290#issuecomment-463620334
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190214/01e9f746/attachment.html>


More information about the notifications mailing list