[riot-notifications] [RIOT-OS/RIOT] drivers/gsm: add a (generic) gsm driver, with support for UBlox and Quectel. (#10086)

Toon Stegen notifications at github.com
Thu Feb 14 14:56:23 CET 2019


toonst commented on this pull request.



> +#ifndef QUECTEL_RESET_TIME_US
+#define QUECTEL_RESET_TIME_US                   (500 * US_PER_MS)
+#endif
+
+/**
+ * @brief Quectel gsm device parameters
+ */
+typedef struct gsm_quectel_params {
+    gsm_params_t base;              /**< gsm base parameters */
+    gpio_t      power_pin;          /**< quectel power pin*/
+    bool        invert_power_pin;   /**< select inversion of power pin */
+    gpio_t      status_pin;         /**< quectel status pin (modem output) */
+    bool        invert_status_pin;  /**< select inversion of status pin */
+    gpio_t      reset_pin;          /**< quectel reset pin*/
+    bool        invert_reset_pin;   /**< select inversion of reset pin*/
+    gpio_t      dtr_pin;            /**< quectel dtr pin (modem intput) */

this `dtr_pin` seems to be very common in modem equipment. I think it makes sense to make it part of the gsm params, similar to the `ri_pin`. Also, typo in comment: `intput`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10086#pullrequestreview-203754034
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190214/189a37fb/attachment-0001.html>


More information about the notifications mailing list