[riot-notifications] [RIOT-OS/RIOT] tools/serial.inc.mk: Support miniterm.py. (#11003)

Alexandre Abadie notifications at github.com
Thu Feb 14 23:06:22 CET 2019


aabadie requested changes on this pull request.

It's indeed useful to provide support for miniterm even if it's not the default.
I haven't tried this PR but I think local echo should also be enabled by default. There are also a couple minor issues.

> @@ -1,4 +1,5 @@
 DEVELHELP=0
+

unrelated

> @@ -12,4 +13,8 @@ BOARD_BLACKLIST += chronos
 
 TEST_ON_CI_WHITELIST += all
 
+ifneq ($(BOARD), native)
+	RIOT_TERMINAL=miniterm.py

Looks like there's tab here. The indent should be 2 spaces.

> @@ -19,4 +19,7 @@ ifeq ($(RIOT_TERMINAL),pyterm)
 else ifeq ($(RIOT_TERMINAL),picocom)
     export TERMPROG  ?= picocom
     export TERMFLAGS ?= --nolock --imap lfcrlf --echo --baud "$(BAUD)" "$(PORT)"
+else ifeq ($(RIOT_TERMINAL),miniterm.py)
+    export TERMPROG  ?= miniterm.py
+    export TERMFLAGS ?= --eol CRLF "$(PORT)" "$(BAUD)"

Maybe also enable `--echo` ? It's the kind of useful things when using the shell.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11003#pullrequestreview-203993588
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190214/81d54eeb/attachment.html>


More information about the notifications mailing list