[riot-notifications] [RIOT-OS/RIOT] drivers/lpsxxx: refactor lps331ap and add support for lps25hb + lps22hb (#10695)

Sebastian Meiling notifications at github.com
Fri Feb 15 11:20:47 CET 2019


smlng commented on this pull request.



> +    LPSXXX_RATE_7HZ = 2,        /**< sample with 7Hz, default */
+    LPSXXX_RATE_12HZ5 = 3,      /**< sample with 12.5Hz */
+    LPSXXX_RATE_25HZ = 4        /**< sample with 25Hz */
+#elif MODULE_LPS22HB
+    LPSXXX_RATE_10HZ = 2,       /**< sample with 10Hz */
+    LPSXXX_RATE_25HZ = 3,       /**< sample with 25Hz, default */
+    LPSXXX_RATE_50HZ = 4,       /**< sample with 50Hz */
+    LPSXXX_RATE_75HZ = 5        /**< sample with 75Hz */
+#endif
+} lpsxxx_rate_t;
+
+/**
+ * @brief   The sensors default output data rate (ODR)
+ */
+#if MODULE_LPS331AP || MODULE_LPS25HB
+#define LPSXXX_DEFAULT_RATE     (LPSXXX_RATE_7HZ)

why not simply use `LPSXXX_RATE_1HZ` as default for all?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10695#pullrequestreview-204169088
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190215/68162e48/attachment-0001.html>


More information about the notifications mailing list