[riot-notifications] [RIOT-OS/RIOT] tools/serial.inc.mk: Support miniterm.py. (#11003)

Juan I Carrano notifications at github.com
Tue Feb 19 12:10:49 CET 2019


jcarrano commented on this pull request.



> @@ -1,4 +1,5 @@
 DEVELHELP=0
+

Oops, that slipped through when I splitted the change.

> @@ -19,4 +19,7 @@ ifeq ($(RIOT_TERMINAL),pyterm)
 else ifeq ($(RIOT_TERMINAL),picocom)
     export TERMPROG  ?= picocom
     export TERMFLAGS ?= --nolock --imap lfcrlf --echo --baud "$(BAUD)" "$(PORT)"
+else ifeq ($(RIOT_TERMINAL),miniterm.py)
+    export TERMPROG  ?= miniterm.py
+    export TERMFLAGS ?= --eol CRLF "$(PORT)" "$(BAUD)"

With local echo you end up having _double_ echo, as the shell echoes too, and miniterm does not do line buffering, eg.:

```
> hheellpp
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11003#discussion_r257988235
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190219/486f9ed5/attachment.html>


More information about the notifications mailing list