[riot-notifications] [RIOT-OS/RIOT] Introduce module vars (#10928)

Kaspar Schleiser notifications at github.com
Tue Feb 19 14:26:09 CET 2019


> Be explicit with `CFLAGS += $(call add_module_specific_variables,CFLAGS)`

Pro's and cons. That would lead to:

```
CFLAGS += $(call add_module_specific_variables,CFLAGS)
LINKFLAGS += $(call add_module_specific_variables,LINKFLAGS)
CXXFLAGS += $(call add_module_specific_variables,CXXFLAGS)
ASMFLAGS += $(call add_module_specific_variables,ASMFLAGS)
INCLUDES += $(call add_module_specific_variables,INCLUDES)
USEMODULE_INCLUDES += $(call add_module_specific_variables,USEMODULE_INCLUDES)
...
```

... with probably a growing number. It would also remove the possibility to add variables from within other files, but have them collected at a defined point.

> I would then easily find all things defining CFLAGS with only grep.

Same with using a helper, you'd find CFLAGS mentioned as being added to MODULE_VARS.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10928#issuecomment-465126893
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190219/3b828ad1/attachment-0001.html>


More information about the notifications mailing list