[riot-notifications] [RIOT-OS/RIOT] sys: Add RIOT Registry implementation (#10799)

danpetry notifications at github.com
Wed Feb 20 14:51:59 CET 2019


danpetry commented on this pull request.



> +#endif /* CONFIG_REGISTRY_USE_FLOAT */
+} registry_type_t;
+
+
+/**
+ * @brief Prototype of a callback function for the load action of a store
+ * interface
+ */
+typedef void (*load_cb_t)(char *name, char *val, void *cb_arg);
+
+/**
+ * @brief Descriptor used to check duplications in store facilities
+ */
+typedef struct {
+    char *name; /**< name of the parameter being checked */
+    char *val;  /**< value of the parameter being checked */

Ah I see, the name and value have to both be the same for it to be marked as a duplicate. Which means that the storage facility won't try to store it. If the name is the same but the value is different then it will store it. I guess this is a runtime optimization? Wouldn't it be better to cut out the duplicate checking and just always save over the existing entry in the storage facility, to save ROM? Also it seems like this duplicate checking would take a while for a large registry size

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10799#discussion_r258489321
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190220/88a7cff5/attachment.html>


More information about the notifications mailing list