[riot-notifications] [RIOT-OS/RIOT] cpu/kinetis: fix values stored in ROM_LEN/RAM_LEN variables (#10888)
notifications at github.com
Fri Feb 22 11:28:20 CET 2019
The reason why it would be needed to change to `$(shell)` or change to an explicit value is that the variable value must not only be used from recipes where `$(())` will correctly be evaluated but also but also directly from within the makefiles.
It was not the case before but now ROM_LEN is used and evaluated from within the makefiles so is supposed to be a variable with a valid value. It is currently not needed for `kinetis`, but if we want to try using the same `riotboot/` and `cortexm_common` mechanism, it would need to be harmonized.
The simplest solution would be to do `ROM_LEN = $(KINETIS_ROMSIZE)K`
This requires no shell evaluation and the linker and `cortexm_common/Makefile.include` handles the 'K'.
RAM_LEN cannot as it is can be `256/8` and adding a K after breaks it but it is not needed for `riotboot`.
Another solution, would be to change `KINETIS_ROMSIZE` to be in `bytes` and not in `kibytes` and then also change `KINETIS_RAMSIZE` and `KINETIS_SRAM_L_SIZE` to be in `bytes`.
But it would be a lot more line changes than the other one for maybe no real benefit.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications