[riot-notifications] [RIOT-OS/RIOT] feather-m0: add BAT voltage ADC line (A7) (#10938)

Hauke Petersen notifications at github.com
Fri Feb 22 13:32:12 CET 2019


haukepetersen requested changes on this pull request.

simply skip the undefined line 6 and adapt the values below accordingly. Else looks good from my side.

> @@ -177,9 +177,11 @@ static const adc_conf_chan_t adc_channels[] = {
     { GPIO_PIN(PA, 4), ADC_INPUTCTRL_MUXPOS_PIN4 },     /* A3 */
     { GPIO_PIN(PA, 5), ADC_INPUTCTRL_MUXPOS_PIN5 },     /* A4 */
     { GPIO_PIN(PB, 2), ADC_INPUTCTRL_MUXPOS_PIN10 },    /* A5 */
+    { GPIO_UNDEF, 0 },                                  /* not defined */

this doesn't make sense, as the RIOT's mapping does not care about the internal ADC channels, so AIN[7] does not need to be on position 7 in this config array. From RIOT's user perspective, you would simply use RIOT's logical line 6, which is mapped to the CPU's channel AIN[7].

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10938#pullrequestreview-206795735
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190222/cb84db33/attachment.html>


More information about the notifications mailing list