[riot-notifications] [RIOT-OS/RIOT] drivers/ph_oem: support for Atlas Scientific pH OEM sensor (#10983)

Igor Knippenberg notifications at github.com
Sat Feb 23 22:42:41 CET 2019


skullbox305 commented on this pull request.



> +    if (i2c_read_reg(I2C, ADDR, PH_OEM_REG_CALIBRATION_CONFIRM,
+                     calibration_state, 0) < 0) {
+        DEBUG("\n[ph_oem debug] Failed at reading calibration confirm register\n");
+        i2c_release(I2C);
+        return PH_OEM_READ_ERR;
+    }
+    i2c_release(I2C);
+    return PH_OEM_OK;
+}
+
+int ph_oem_set_compensation(const ph_oem_t *dev,
+                            uint16_t temperature_compensation)
+{
+    uint8_t reg_value[4];
+
+    reg_value[0] = 0x00;

- added a range check and new named error return for an out of range case
- added the constraint in the documentation

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10983#discussion_r259594221
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190223/5e0b2432/attachment.html>


More information about the notifications mailing list