[riot-notifications] [RIOT-OS/RIOT] drivers/ph_oem: support for Atlas Scientific pH OEM sensor (#10983)

Igor Knippenberg notifications at github.com
Sat Feb 23 22:48:31 CET 2019


skullbox305 commented on this pull request.



> +
+int ph_oem_set_led_state(const ph_oem_t *dev, ph_oem_led_state_t state)
+{
+    i2c_acquire(I2C);
+
+    if (i2c_write_reg(I2C, ADDR, PH_OEM_REG_LED, state, 0x0) < 0) {
+        DEBUG("\n[ph_oem debug] Setting LED state to %d failed.\n", state);
+        i2c_release(I2C);
+        return PH_OEM_WRITE_ERR;
+    }
+    i2c_release(I2C);
+
+    return PH_OEM_OK;
+}
+
+int ph_oem_enable_device(const ph_oem_t *dev, bool enable)

Yes you are right, it makes not sense. I removed all lines related to the enable pin

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10983#discussion_r259594375
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190223/9359d305/attachment.html>


More information about the notifications mailing list