[riot-notifications] [RIOT-OS/RIOT] serial.inc.mk: disable local echo in minicom. (#11062)

Juan I Carrano notifications at github.com
Mon Feb 25 16:59:18 CET 2019


### Contribution description

Due to a recent fix in shell.c (#10630), remote echo is now working as originally intended. Local echo must be disabled or otherwise it will add up to the remote one, causing a character-by-character double echoing.

### Testing procedure

Note: exit picocom by typing Ctrl-a Ctrl-x.

Run `RIOT_TERMINAL=picocom BOARD=samr21-xpro make -C tests/shell term`

Without this fix:

```
Type [C-a] [C-h] to see available commands
Terminal ready


> hheellpp

Command              Description
---------------------------------------
start_test           starts a test
end_test             ends a test
echo                 prints the input command
reboot               Reboot the node
ps                   Prints information about running threads.
> <type enter here>
<empty line that shoul not exist>
>
```

With this fix:

```
> help
Command              Description
---------------------------------------
start_test           starts a test
end_test             ends a test
echo                 prints the input command
reboot               Reboot the node
ps                   Prints information about running threads.
>  <note no empty line after typing enter here>
>
```


### Issues/PRs references

See #10630 .
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11062

-- Commit Summary --

  * serial.inc.mk: disable local echo in minicom.

-- File Changes --

    M makefiles/tools/serial.inc.mk (2)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11062.patch
https://github.com/RIOT-OS/RIOT/pull/11062.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11062
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190225/7f16690a/attachment.html>


More information about the notifications mailing list