[riot-notifications] [RIOT-OS/RIOT] boards/nz32-sc151: do not blindly set TERMFLAGS (#11065)

Gaƫtan Harter notifications at github.com
Mon Feb 25 18:03:33 CET 2019


### Contribution description

The board should not globally set `TERMFLAGS` without a RIOT_TERMINAL
condition.

Also the board does not export uart through usb and thus needs an uart
converter connected. Other boards in the same situation do not need
to set `TERMPROG` without a valid baudrate. So remove the definition
anyway.

This also removes the export of TERM* variables and should make it work
with the other RIOT_TERMINAL.

https://github.com/RIOT-OS/RIOT/blob/7e0891ebe5e3c090b0b058929eb8ab16ded57d7e/boards/nz32-sc151/doc.txt#L56-L61

### Testing procedure

I do not have the board here but testing the board with an external uart should still work.
@aabadie 

Also you can review the commit message if it makes sense for the board or not.

### Issues/PRs references

Tracking issue: https://github.com/RIOT-OS/RIOT/issues/10850
Found while working on https://github.com/RIOT-OS/RIOT/pull/10952

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/11065

-- Commit Summary --

  * boards/nz32-sc151: do not blindly set TERMFLAGS

-- File Changes --

    M boards/nz32-sc151/Makefile.include (1)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/11065.patch
https://github.com/RIOT-OS/RIOT/pull/11065.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11065
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190225/14ab52ef/attachment-0001.html>


More information about the notifications mailing list