[riot-notifications] [RIOT-OS/RIOT] drivers/sx127x: rework of implementations from #6645 and #6002 (#6797)

Martine Lenders notifications at github.com
Tue Feb 26 15:18:53 CET 2019


miri64 commented on this pull request.



> +
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+/**
+ * @brief   Reference to the netdev device driver struct
+ */
+extern const netdev_driver_t sx127x_driver;
+
+/**
+ * @brief   Received LoRa packet status information
+ */
+typedef struct netdev_radio_lora_packet_info {
+    uint8_t rssi;           /**< RSSI of a received packet */
+    uint8_t lqi;            /**< LQI of a received packet */

I just had a look at this code again due to an unrelated issue I discussed with @kYc0o, so sorry for the "late review" ;-).

In the [`recv()` function of this driver](https://github.com/RIOT-OS/RIOT/pull/6797/files#diff-37ee9c4f2a20ec7a38d429c04255744aR155) it says that LoRA has no LQI, so why is it in this struct?

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/6797#pullrequestreview-207979082
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190226/853638b8/attachment.html>


More information about the notifications mailing list