[riot-notifications] [RIOT-OS/RIOT] sys/posix: make posix module provide only headers. (#10357)

Martine Lenders notifications at github.com
Tue Feb 26 18:53:06 CET 2019


miri64 requested changes on this pull request.

The change is making sense mostly. Just one dependency is missing (which would make one addition redundant)

> @@ -1,4 +1,5 @@
 ifneq (,$(filter libcoap,$(USEPKG)))
   USEMODULE += posix_sockets
+  USEMODULE += posix

`posix_socket` should pull in `posix` as a dependency, shouldn't it? It would make sense at least.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10357#pullrequestreview-208111135
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190226/9e242d31/attachment.html>


More information about the notifications mailing list