[riot-notifications] [RIOT-OS/RIOT] [WIP] gnrc_lorawan: add initial support for gnrc based LoRaWAN stack (v2) (#11022)

Martine Lenders notifications at github.com
Tue Feb 26 19:31:22 CET 2019


miri64 requested changes on this pull request.

Some comments initial comments before I realized this PR is still WIP

> @@ -250,6 +250,7 @@ typedef enum {
 struct netdev_radio_rx_info {
     int16_t rssi;       /**< RSSI of a received packet in dBm */
     uint8_t lqi;        /**< LQI of a received packet */
+    int8_t snr;         /**< SNR of a received packet in dBm */

There is misplaced struct in [`drivers/sx127x/include/sx127x_netdev.h`](https://github.com/RIOT-OS/RIOT/blob/cebea3a23ed8ea101912e5133f6e73b4634fb46c/drivers/sx127x/include/sx127x_netdev.h) that you could move to a more generic position (e.g. `drivers/include/net/netdev/lora.h`) instead of changing the API here.

> @@ -250,6 +250,7 @@ typedef enum {
 struct netdev_radio_rx_info {
     int16_t rssi;       /**< RSSI of a received packet in dBm */
     uint8_t lqi;        /**< LQI of a received packet */
+    int8_t snr;         /**< SNR of a received packet in dBm */

Also note https://github.com/RIOT-OS/RIOT/pull/6797#discussion_r260303912

>  
-    dev->event_callback(dev, NETDEV_EVENT_RX_TIMEOUT);
+    //dev->event_callback(dev, NETDEV_EVENT_RX_TIMEOUT);

TODO? Please mark the PR as WIP if so.

> +
+
+#define ADR_MASK 0x80
+#define ADR_ACK_REQ_MASK 0x40
+#define ACK_MASK 0x20
+#define FPENDING_MASK 0x10
+#define FOPTS_MASK 0x0F
+
+
+#define JOIN_REQUEST_SIZE 23
+#define MIC_SIZE 4
+
+#define LORAWAN_STATE_IDLE (0)
+#define LORAWAN_STATE_RX_1 (1)
+#define LORAWAN_STATE_RX_2 (2)
+#define LORAWAN_STATE_TX (3)

Here and above: style

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11022#pullrequestreview-208130174
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190226/2cd3581b/attachment.html>


More information about the notifications mailing list