[riot-notifications] [RIOT-OS/RIOT] suit: Initial minimal CBOR-based SUIT manifest parser (#10315)

Kaspar Schleiser notifications at github.com
Wed Feb 27 10:20:12 CET 2019


kaspar030 commented on this pull request.



> + *
+ * The parser is based on draft version 1 of the specification.
+ *
+ * @see https://tools.ietf.org/html/draft-moran-suit-manifest-01
+ *
+ * @{
+ *
+ * @brief       Decoding functions for a SUIT manifest
+ * @author      Koen Zandberg <koen at bergzand.net>
+ */
+
+#ifndef SUIT_H
+#define SUIT_H
+
+#ifdef __cplusplus
+extern "C" {

> is there a rule/guideline for the order of this somewhere?

"do as we always did" combined with "close in reversed open order":

- copyright
- doxygen open (with file info)
- header guard open
- includes
- ifdef c++ open
- code
- ifdef c++ close
- header guard close
- doxygen close

for the includes it is somewhat important to be before the "extern C" as they *might* have other namespacing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10315#discussion_r260655888
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190227/5f2d65cf/attachment.html>


More information about the notifications mailing list