[riot-notifications] [RIOT-OS/RIOT] makefiles/tools: Improved avrdude integration (#11039)
notifications at github.com
Thu Feb 28 08:52:11 CET 2019
smlng requested changes on this pull request.
> @@ -6,10 +6,16 @@ DEBUGSERVER_FLAGS = "-g -j usb :$(DEBUGSERVER_PORT)"
DEBUGGER_FLAGS = "-x $(RIOTBOARD)/$(BOARD)/dist/gdb.conf $(ELFFILE)"
DEBUGGER = $(DIST_PATH)/debug.sh $(DEBUGSERVER_FLAGS) $(DIST_PATH) $(DEBUGSERVER_PORT)
-# make the flasher port configurable (e.g. with atmelice the port is usb)
-# defaults to terminal's serial port if not configured
-AVRDUDE_PORT ?= $(PORT)
-PROGRAMMER_FLAGS = -P $(AVRDUDE_PORT) $(FFLAGS_EXTRA)
+PROGRAMMER_FLAGS = -p $(CPU:atmega=m)
on MacOS this doesn't seem to work, for Arduino-Mega2560 I get:
avrdude -c stk500v2 -p atmega2560 -P ...
while on master it is `m2560` bc explicitly set. HOWEVER, funnily it even works with that - but maybe that's just a coincidence and we should not rely on that.
This does not seem to be related to `make`, I tried with the default on MacOS which is version 3.81 and with one installed via HomeBrew which is 4.2.1.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications