[riot-notifications] [RIOT-OS/RIOT] makefiles/docker.inc.mk: Use directories in RIOT when possible (#9646)

Gaƫtan Harter notifications at github.com
Thu Feb 28 15:01:52 CET 2019


cladmi commented on this pull request.



>  	    $(DOCKER_ENVIRONMENT_CMDLINE) \
-	    -w '$(DOCKER_BUILD_ROOT)/riotproject/$(BUILDRELPATH)' \
+	    -w '$(DOCKER_APPDIR)' \
 	    '$(DOCKER_IMAGE)' make $(DOCKER_MAKECMDGOALS) $(DOCKER_OVERRIDE_CMDLINE)

Some local tested solution for this, configured from outside so re-using `DOCKER_MAKECMDGOALS`.

```
# Extract parallel option
# The number of jobs is only available after make 4.2
# The value will not be available in make but in the targets body
MAKE_PARALLEL = $(filter -j -j%,$(MAKEFLAGS))
DOCKER_MAKECMDGOALS += $(MAKE_PARALLEL)
```

We would get `-j` even when saying `-j2` for make before `4.2` so would only pass `-j` in ubuntu bionic. But it could still be good.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/9646#discussion_r261207071
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190228/b2cc3c3d/attachment-0001.html>


More information about the notifications mailing list